Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] [PATCH] hang in qcow2raw

To: <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [PATCH] hang in qcow2raw
From: "Charles Coffing" <ccoffing@xxxxxxxxxx>
Date: Fri, 30 Mar 2007 15:37:41 -0400
Delivery-date: Fri, 30 Mar 2007 20:39:04 +0100
Envelope-to: Keir.Fraser@xxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi, 

We hit a bug in which qcow2raw would hang the conversion just short of 100%, 
because the final write queue was never being submitted.  If a blktap drivers 
read synchronously, then "submit_events" and "complete" variables are checked 
before getting set, so the fact that reads have finished is not noticed, so the 
final write queue was never submitted.

Note that I have also removed the variables write_complete and read_complete.  
They were unused, and they were also not set correctly in the synchronous case.

Patch attached; please apply to xen-unstable.

Thanks.

Signed-off-by: Charles Coffing <ccoffing@xxxxxxxxxx>

Attachment: qcow2raw-hang.patch
Description: Text document

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [PATCH] hang in qcow2raw, Charles Coffing <=