Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] Re: [patch 06/26] Xen-paravirt_ops: paravirt_ops: allocate a

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] Re: [patch 06/26] Xen-paravirt_ops: paravirt_ops: allocate a fixmap slot
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Tue, 27 Feb 2007 16:49:53 -0800
Cc: Zachary Amsden <zach@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxx>, Rusty Russell <rusty@xxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Chris Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Ingo Molnar <mingo@xxxxxxx>, Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 27 Feb 2007 16:49:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <45E47E95.2060803@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070227081337.434798469@xxxxxxxx> <20070227081631.122933982@xxxxxxxx> <20070227101143.GC10827@xxxxxxx> <45E47E95.2060803@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (X11/20070212)
Jeremy Fitzhardinge wrote:
> Ingo Molnar wrote:
>   
>> why not vmalloc it on the guest side? fixmaps are bad for this purpose 
>> for a general paravirt implementation, it limits the size of the shared 
>> info page, etc.
>>     
>
> Yes.  vmalloc would have the annoying side-effect of actually allocating
> some pages which would be shadowed by the remapping, but I guess
> get_vm_area would do the job.  I'll give it a go.

Hm, this is a bit awkward.  We need to map the shared info page fairly
early - say, around paging_init - but we're still on the bootmem
allocator at that point, so get_vm_area isn't usable yet.  Using a
fixmap keeps things simple.  It seems to me that having a single fixmap
available is useful for this kind of simple/early mapping, and if
someone needs to map something larger, then they can put it off until
get_vm_area() is available...

    J

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>