Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] [XEN] [ACM] Simplify the event channel scanning

To: Stefan Berger <stefanb@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [XEN] [ACM] Simplify the event channel scanning
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 27 Feb 2007 19:02:36 +0000
Delivery-date: Tue, 27 Feb 2007 11:01:56 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1172596799.31444.2.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcdaodfLFoYi7saVEduLoQAX8io7RQ==
Thread-topic: [PATCH] [XEN] [ACM] Simplify the event channel scanning
User-agent: Microsoft-Entourage/11.2.5.060620
On 27/2/07 17:19, "Stefan Berger" <stefanb@xxxxxxxxxx> wrote:

> This patch simplifies the scanning of a domain's event channels
> considering that an 'ECS_UNBOUND' event channel is not connected and can
> be skipped.
> 
> Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>

This code is still broken: you are checking only the first event-channel in
each bucket. You need a double loop: the new inner loop should iterate from
0 to EVTCHNS_PER_BUCKET-1.

ports = d->evtchn[bucket];
If ( ports == NULL )
    break;
for ( j = 0; j < EVTCHNS_PER_BUCKET; j++ )
  .... process ports[j] ....

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>