Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [PATCH] new domain builder setup hook clean up (was Re: [Xen-devel]

To: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Subject: Re: [PATCH] new domain builder setup hook clean up (was Re: [Xen-devel] [PATCH] new domain builder fix to boot domU on IA64.)
From: Gerd Hoffmann <kraxel@xxxxxxx>
Date: Thu, 01 Feb 2007 08:59:33 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 31 Jan 2007 23:59:33 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070201025719.GE23150%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070130122631.GI25482%yamahata@xxxxxxxxxxxxx> <45BF50EC.4020300@xxxxxxx> <20070131025608.GE23281%yamahata@xxxxxxxxxxxxx> <45C08456.4080903@xxxxxxx> <20070201025719.GE23150%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.9 (X11/20060911)
  Hi,

> @@ -438,7 +434,7 @@ int xc_dom_boot_mem_init(struct xc_dom_i
>       return rc;
>      }
>  
> -    if (0 != (rc = arch_setup_middle(dom)))
> +    if (0 != (rc = arch_setup_bootearly(dom)))
>          return rc;
>  
>      return 0;

> @@ -497,6 +493,10 @@ int xc_dom_boot_image(struct xc_dom_imag
>  
>      xc_dom_printf("%s: called\n", __FUNCTION__);
>  
> +    /* misc ia64 stuff*/
> +    if (0 != (rc = arch_setup_bootearly(dom)))
> +     return rc;
> +
>      /* collect some info */
>      domctl.cmd = XEN_DOMCTL_getdomaininfo;
>      domctl.domain = dom->guest_domid;

Hmm, bootearly() is called twice now, I guess the first call in
mem_init() should have been removed?  Otherwise the patch looks fine to me.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@xxxxxxx>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel