[Xen-devel] Re: [Xen-staging] [xen-unstable] ia64, ppc: Remove uses of sprintf().

[Alex Williamson <alex.williamson@xxxxxx>]

On Tue, 2007-01-30 at 16:14 +0000, Xen staging patchbot-unstable wrote:
> diff -r 300c47bec138 -r bd69e83b65ea xen/arch/ia64/linux-xen/setup.c
> --- a/xen/arch/ia64/linux-xen/setup.c Tue Jan 30 16:09:16 2007 +0000
> +++ b/xen/arch/ia64/linux-xen/setup.c Tue Jan 30 16:14:16 2007 +0000
> @@ -550,7 +550,7 @@ show_cpuinfo (struct seq_file *m, void *
>       switch (c->family) {
>             case 0x07:        memcpy(family, "Itanium", 8); break;
>             case 0x1f:        memcpy(family, "Itanium 2", 10); break;
> -           default:          sprintf(family, "%u", c->family); break;
> +           default:          snprintf(family, sizeof(family), "%u", 
> c->family); break;
>       }

   What's the purpose of all this "cleanup"?  This is just munging files
that we're leveraging from Linux, making updating them later on more
difficult.  And these really should have been submitted via the
xen-ia64-devel list.

        Alex

-- 
Alex Williamson                             HP Open Source & Linux Org.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel