RE: [Xen-devel] [Block issue] VMX status report 13161:a9a43705f26b

["Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>]

>Xiaowei: I'm pretty sure I can eyeball bugs in the new vpt.c code. For
>example, how can it be right that last_plt_gtime is incremented by
period in
>some places and period_cycles in others? The two quantities have
different
>units!
> 

Keir,
Sorry for the neglect! The quick fix is as below. 
diff -r a9a43705f26b xen/arch/x86/hvm/vpt.c
--- a/xen/arch/x86/hvm/vpt.c    Wed Dec 27 00:38:01 2006 +0000
+++ b/xen/arch/x86/hvm/vpt.c    Thu Dec 28 17:37:17 2006 +0800
@@ -109,9 +109,9 @@ void pt_update_irq(struct vcpu *v)
     {
         pt = list_entry(list, struct periodic_time, list);
         if ( !is_irq_masked(v, pt->irq) && pt->pending_intr_nr
-                && pt->last_plt_gtime + pt->period < max_lag )
-        {
-            max_lag = pt->last_plt_gtime + pt->period;
+                && pt->last_plt_gtime + pt->period_cycles < max_lag )
+        {
+            max_lag = pt->last_plt_gtime + pt->period_cycles;
             irq = pt->irq;
         }
     }

We are double checking the patches!

Thanks, 
Xiaowei

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel