Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] 13120:3e2d3d737624 breaks Solaris compile

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] 13120:3e2d3d737624 breaks Solaris compile
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 22 Dec 2006 14:29:57 +0000
Delivery-date: Fri, 22 Dec 2006 06:28:41 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
The changes to xentop.c:

-                       vwprintw(stdscr, (char *)fmt, args);
+                       vwprintw(stdscr, (const char *)fmt, args);
-       addstr((char *)str);
+       addstr((const char *)str);

Are both unneccessary on Linux (as they're const char * already), and
broken on Solaris, where we have rather unfortunate prototypes from
pre-history that aren't constified. I think these need to be reverted
back to being the meaningful '(char *)'.

regards,
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>