Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] non-flat protected mode HVM support

To: Jan Beulich <jbeulich@xxxxxxxxxx>, Trolle Selander <trolle.selander@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] non-flat protected mode HVM support
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 29 Nov 2006 15:38:22 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 29 Nov 2006 07:39:24 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <456DB30C.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccTzGappTvODH+/EducNwAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] non-flat protected mode HVM support
User-agent: Microsoft-Entourage/11.2.5.060620
On 29/11/06 15:19, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> Indeed, I didn't look outside the hvm directories. But it's not just the
> instruction
> fetching there, there are other segment based operations in there, too. Hence
> I think adding a callback to obtain the base address would be cleaner;
> hvm_get_segment_base() could be used in the hvm case, and a simple function
> should be put in place for pv guest handling (for those, assuming a zero base
> address seems reasonably safe at this point, since the behavior of them is
> known, and if ever page table updates get done through segments with non-
> zero base addresses this would need to be revisited.
> 
> I'll try to take care of this unless you beat me.

I have a big patch outstanding on the x86_emulate code to simplify the
interface and properly support page-straddling data operands and non-zero
segment bases.

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel