Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [XENOPROF] fix shared_xenoprof_page_with_guest()

To: "Woller, Thomas" <thomas.woller@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [XENOPROF] fix shared_xenoprof_page_with_guest() and clean up
From: Isaku Yamahata <yamahata@xxxxxxxxxxxxx>
Date: Wed, 29 Nov 2006 12:29:51 +0900
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 28 Nov 2006 19:30:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <683860AD674C7348A0BF0DE3918482F603BF4500@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061128082003.GC22677%yamahata@xxxxxxxxxxxxx> <683860AD674C7348A0BF0DE3918482F603BF4500@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.2.1i
Attached the patch. please find it.
I could compile with this patch on x86_64 successfully.
If this patch doesn't solve for you, can you send compilation log?

On Tue, Nov 28, 2006 at 05:32:44PM -0600, Woller, Thomas wrote:
> Isaku,
> When xenoprof is enabled in the 64bit linux dom0, then during the build,
> the xenoprof.h include file is not found, and dom0 fails to build with
> an error.
> It looks like there is no soft link to the i386 version created, but I
> am not sure of all of your cleanup modifications and how the build
> should actually occur using the i386 xenoprof.h file for x86_64 build. 
> Can you provide fix? 
> Thanks,
> Tom 
> 
> > -----Original Message-----
> > From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
> > [mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of 
> > Isaku Yamahata
> > Sent: Tuesday, November 28, 2006 2:20 AM
> > To: xen-devel@xxxxxxxxxxxxxxxxxxx
> > Subject: [Xen-devel] [PATCH] [XENOPROF] fix 
> > shared_xenoprof_page_with_guest() and clean up
> > 
> > 
> > Without this patch, profiling more than twice causes xen 
> > panic because of page reference counter inconsistency.
> > 
> > [XENOPROFILE] fix shared_xenoprof_page_with_guest() and clean up.
> > - share_xenoprof_page_with_guest() must check page reference 
> > count manually
> >   and clear the page owner in order to keep page_info consistency.
> >   free_domheap_pages() called by put_page() doesn't clear page owner.
> >   It's intentional. On the other hand, 
> > share_xen_page_with_guest() checks
> >   whether the page owner is already a requested one at first. If so,
> >   it simply returns doing nothing because 
> > share_xen_page_with_guest() expects
> >   freshly allocated pages or already shared one and doesn't expect
> >   put_page()-and-free_domheap_pages() pages or pages shared with
> >   another domains.
> > - clean up
> >   remove unsed argument gmaddr of alloc_xenoprof_buf(), 
> > alloc_xenoprof_struct()
> > 
> > --
> > yamahata
> > 
> 
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
> 

-- 
yamahata

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel