[Xen-devel] Re: [PATCH][VNC Auth] Fix qemu-dm becomes defunct wh

To:	Masami Watanabe <masami.watanabe@xxxxxxxxxxxxxx>, "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH][VNC Auth] Fix qemu-dm becomes defunct when rebooting hvm domain
From:	Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date:	Mon, 30 Oct 2006 13:35:58 +0000
Cc:	Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, Anthony Liguori <aliguori@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, "Zheng, Jeff" <jeff.zheng@xxxxxxxxx>
Delivery-date:	Mon, 30 Oct 2006 05:40:10 -0800
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<JU200610302129275.2081343@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	Acb8KFTnk2Q33WgbEdudPAAX8io7RQ==
Thread-topic:	[PATCH][VNC Auth] Fix qemu-dm becomes defunct when rebooting hvm domain
User-agent:	Microsoft-Entourage/11.2.5.060620

On 30/10/06 12:29, "Masami Watanabe" <masami.watanabe@xxxxxxxxxxxxxx> wrote:

> - When vncpasswd cannot be read from xenstore, qemu-dm is exit(1).
>   As a result, qemu-dm becomes defunct process.

No, xenstore_read_vncpasswd() bails but returns 0, so the caller does not
exit(). Otherwise we could not run with authentication disabled (xend does
not write empty passwd strings to xenstore).

 -- Keir

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

xen-devel

[Xen-devel] Re: [PATCH][VNC Auth] Fix qemu-dm becomes defunct when reboo