[Xen-devel] Re: [Xen-changelog] [xen-unstable] [VMXASSIST] Cast to pointer type via long to avoid compile

[Rik van Riel <riel@xxxxxxxxxx>]

Xen patchbot-unstable wrote:

> [VMXASSIST] Cast to pointer type via long to avoid compile
> warnings/errors with latest gcc versions.
> Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
Are you sure you don't want these to be unsigned, seeing that
the x86-64 kernels have the top bit set for kernel addresses?

> diff -r 5c522692edd1 -r 1d0e75523636 tools/firmware/vmxassist/vm86.c
> --- a/tools/firmware/vmxassist/vm86.c   Wed Sep 27 16:22:17 2006 +0100
> +++ b/tools/firmware/vmxassist/vm86.c   Wed Sep 27 17:49:22 2006 +0100
> @@ -68,7 +68,7 @@ guest_linear_to_real(uint32_t base)
>                 return base;
>  
>  	if (!(oldctx.cr4 & CR4_PAE)) {
> -               l1_mfn = ((uint32_t *)gcr3)[(base >> 22) & 0x3ff];
> +               l1_mfn = ((uint32_t *)(long)gcr3)[(base >> 22) & 0x3ff];
--
All Rights Reversed

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel