Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] Re: [PATCH] Fix gdbserver-xen build errors

To: Travis Betak <travis.betak@xxxxxxx>, Horms <horms@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [PATCH] Fix gdbserver-xen build errors
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 31 Aug 2006 19:47:56 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 31 Aug 2006 11:48:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.62.0608311230220.5417@twinkletoes01>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbNLfjqN54rMDkhEdu48AAKle7CWA==
Thread-topic: [Xen-devel] Re: [PATCH] Fix gdbserver-xen build errors
User-agent: Microsoft-Entourage/11.2.5.060620


On 31/8/06 7:14 pm, "Travis Betak" <travis.betak@xxxxxxx> wrote:

> I guess it was not the correct fix =)
> 
> Yeah, I didn't take into account any predefined CFLAGS or MAKE.  So your
> patch is much better.
> 
> Perhaps a better place to put the define is in the gdbserver-xen sparse
> directory's Makefile.in.  That will narrow the scope of the define a
> bit.  How does the following look to you? ...or something similar?

I just checked in a more general fix, which simply defines the macro in
xenctrl.h if it isn't defined already.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>