Re: [Xen-devel] [PATCH] wrong accounting in direct_remap_pfn_range

[Steven Rostedt <srostedt@xxxxxxxxxx>]

Steven Rostedt wrote:
> Keir Fraser wrote:
> > I think you're confused. 
> I usually am :)  But not on this one :P
grr, I take it back, I am the one that's confused :P


OK, this all happens because this whole blob of code is crazy because it 
is missing a "if (size == 0)" check!
The "if (v != u)" is only not true when this function is called with 
size == 0, and we don't need to do anything.  Why not just have that 
check in the beginning and remove the "if (v != u)"?
It would have saved me a lot of wasted time here.  Or is this code meant 
to confuse me?
Sorry,


-- Steve

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel