Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] Re: [Xen-changelog] [xen-unstable] [IA64] Creates tools/libx

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] Re: [Xen-changelog] [xen-unstable] [IA64] Creates tools/libxc/ia64 directory.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Fri, 28 Jul 2006 14:17:24 -0500
Cc: xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>, xen-ia64-devel <xen-ia64-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 28 Jul 2006 12:17:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1G6V58-0001q8-KH@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <E1G6V58-0001q8-KH@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2006-07-28 at 16:20 +0000, Xen patchbot-unstable wrote:
> diff -r dc26ac2f7718 -r dab0a5650e6d tools/libxc/Makefile
> --- a/tools/libxc/Makefile      Mon Jul 10 14:14:11 2006 -0600
> +++ b/tools/libxc/Makefile      Tue Jul 11 11:29:25 2006 -0600
> @@ -30,9 +30,11 @@ GUEST_SRCS-y += xc_load_bin.c
>  GUEST_SRCS-y += xc_load_bin.c
>  GUEST_SRCS-y += xc_load_elf.c
>  GUEST_SRCS-y += xg_private.c
> -GUEST_SRCS-$(CONFIG_IA64) += xc_ia64_stubs.c
>  GUEST_SRCS-$(CONFIG_MIGRATE) += xc_linux_restore.c xc_linux_save.c
>  GUEST_SRCS-$(CONFIG_HVM) += xc_hvm_build.c
> +
> +# This Makefile only adds files if CONFIG_IA64 is y.
> +include ia64/Makefile
>  
>  CFLAGS   += -Werror
>  CFLAGS   += -fno-strict-aliasing 

I'm not sure this is the best way. We'll need to do the same thing for
xc_ppc_linux_build.c, but it seems a little silly to unconditionally
include powerpc/Makefile as well... perhaps
        -include $(XEN_TARGET_ARCH)/Makefile
would suffice?

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>