Re: [Xen-devel] [PATCH] xenconsole: fix xencons=tty[0-9]+ param

To:

Mark McLoughlin <markmc@xxxxxxxxxx>

Subject:

From:

Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>

Date:

Fri, 30 Jun 2006 18:31:50 +0100

Cc:

xen-devel@xxxxxxxxxxxxxxxxxxx

Delivery-date:

Fri, 30 Jun 2006 10:32:10 -0700

Envelope-to:

www-data@xxxxxxxxxxxxxxxxxx

In-reply-to:

<1151686608.6184.67.camel@xxxxxxxxxxxxxxxxxxxxx>

List-help:

<mailto:xen-devel-request@lists.xensource.com?subject=help>

List-id:

Xen developer discussion <xen-devel.lists.xensource.com>

List-post:

<mailto:xen-devel@lists.xensource.com>

List-subscribe:

<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>

List-unsubscribe:

<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>

References:

<1151686608.6184.67.camel@xxxxxxxxxxxxxxxxxxxxx>

Sender:

xen-devel-bounces@xxxxxxxxxxxxxxxxxxx


On 30 Jun 2006, at 17:56, Mark McLoughlin wrote:

        If you boot with e.g. xencons=tty3, then tty1/tty2 aren't valid
devices.

        Attached patch makes it always create valid devices on tty1-tty63, but
all but the one specified by xencons are dummy devices.

Is your change to ttyS correct for anything other than ttyS0? Lookslike you'd incorrectly bind on ttyS0.

Also I see you made a predicate more complicated which is repeated manytimes. Could you hide it behind a suitably named macro? You may need tomake it more complicated still to fix ttyS case...


 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]

Current Thread

[Next in Thread>

Previous by Date:

Re: [Xen-devel] [PATCH] Improve xenbus timeout error message, Keir Fraser

Next by Date:

[Xen-devel] [PATCH][ACM][UPDATE2] python tools and support for resource labeling, Bryan D. Payne

Previous by Thread:

[Xen-devel] [PATCH] xenconsole: fix xencons=tty[0-9]+ param, Mark McLoughlin

Next by Thread:

[Xen-devel] [PATCH][ACM][UPDATE2] python tools and support for resource labeling, Bryan D. Payne

Indexes:

[Date] [Thread] [Top] [All Lists]