Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

[Xen-devel] Re: [RFC][PATCH] synchronize console on BUG()

To: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
Subject: [Xen-devel] Re: [RFC][PATCH] synchronize console on BUG()
From: Horms <horms@xxxxxxxxxxxx>
Date: Thu, 29 Jun 2006 19:01:03 +0900 (JST)
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 30 Jun 2006 03:19:57 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E1Fvahf-0001xr-ME@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: tin/1.8.2-20060425 ("Shillay") (UNIX) (Linux/2.6.16-2-686 (i686))
In article <E1Fvahf-0001xr-ME@xxxxxxxxxxxxxxxxxxxxx> you wrote:
> 
> The following patch syncs (and unsync) the console while we are in the
> BUG() macro.
> 
> The separate externs (which I dislike) for these console calls are
> there because including <xen/console.h> breaks all sorts of files, any
> suggestions on how to solve this is welcome.

Is this breakage because <xen/console.h> doesn't #include all the
headers for the stuff it uses itself? If so could someone coment on
if that is intentional, or if it is something that (generally) wants
fixing.

-- 
Horms                                           
H: http://www.vergenet.net/~horms/          W: http://www.valinux.co.jp/en/


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel