Re: [Xen-devel] [PATCH] linux/x86: Initialize high_memory as early as possible

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 29 Jun 2006, at 15:03, Jan Beulich wrote:

> This didn't seem safe enough to me, and apparently also not to the 
> original
> author (at least I attribute the FIXME comment to this) - after all not
> everything before FIXADDR_START is high memory.
> One could say that under DEBUG_HIGHMEM the check should be more strict
> (so that the subsequent BUG() condition fires in more broken cases), 
> but
> without DEBUG_HIGHMEM it might be left as-is to avoid zapping incorrect
> page table entries.
Any kmap_atomic virtual address should be above FIXADDR_START. You have 
a point about debugging though (e.g., passing a non-atomic kmap address 
to kunmap_atomic).
 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel