Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] This patch fixes several issues related to vmxas

To: "Li, Xin B" <xin.b.li@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] This patch fixes several issues related to vmxassist
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 30 Mar 2006 16:52:31 +0100
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 30 Mar 2006 15:53:34 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <59D45D057E9702469E5775CBB56411F10222A766@pdsmsx406>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <59D45D057E9702469E5775CBB56411F10222A766@pdsmsx406>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 30 Mar 2006, at 15:33, Li, Xin B wrote:

This patch fixes several issues related to vmxassist:
1) AP bring up;
2) RHEL4 IA32e installation;
3) SLES10 IA32e installation;

Can you explain what was wrong with the function this patch changes, and how the patch fixes that problem? The patch looks kludgy to me (as far as I understand) -- apparently trying to differentiate between real-mode and protected-mode segments? Why is that needed? Shouldn't you be looking at the execution mode of the caller (e.g., EFLAGS.VM)?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel