Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

RE: [Xen-ia64-devel] RE: [Xen-devel] [PATCH] Fix access_ok for xen/ia64

To: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: RE: [Xen-ia64-devel] RE: [Xen-devel] [PATCH] Fix access_ok for xen/ia64
From: "Tian, Kevin" <kevin.tian@xxxxxxxxx>
Date: Mon, 27 Feb 2006 23:21:39 +0800
Cc: Xen Devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 27 Feb 2006 15:22:15 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcY7pPuO5ykr2fXNR466n01PqSs4NgABpF9wAAE/+EA=
Thread-topic: [Xen-ia64-devel] RE: [Xen-devel] [PATCH] Fix access_ok for xen/ia64
>From: Tian Kevin
>Sent: 2006年2月27日 22:40
>>From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx]
>>Sent: 2006年2月27日 21:51
>>
>>
>>On 27 Feb 2006, at 13:15, Tian, Kevin wrote:
>>
>>> xen/ia64 uaccess is still linux style with different declaration as
>>> common xen. It's meaningless to patch original file with many #ifdef
>>> XEN, and so instead copy that file to create a new xen specific
>>> uaccess file, with unused lines removed. May need render later.
>>>
>>> Or else it breaks compilation on xen-unstable.
>>>
>>> Signed-off-by Kevin Tian <kevin.tian@xxxxxxxxx>
>>
>>Please, unless you are fixing a regression in unstable, these patches
>>should be going to the ia64 mailing list and initially should be
>>applied to the ia64-unstable tree.
>>
>>  -- Keir
>
>Yes, that's the fix to regression in unstable. Though the issue exists for a 
>long
>time, but common code never triggers it until yesterday. ;-)
>
>Thanks,
>Kevin

To be clearer, the regression is seen with Cset 8972 which firstly uses 
access_ok in common code however ia64 has a different definition. Yes,
 normally ia64 specific changes should go xen-ia64-devel. However 
since I saw the compilation error on xen-unstable, I sent the fix to 
xen-devel to address it directly. 

Sorry for vague description in patch, and let me know if any other issues. 

Thanks,
Kevin

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • RE: [Xen-ia64-devel] RE: [Xen-devel] [PATCH] Fix access_ok for xen/ia64, Tian, Kevin <=