[Xen-devel] RE: [Xen-ia64-devel] cset 8690 blk driver regression

To:	"Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject:	[Xen-devel] RE: [Xen-ia64-devel] cset 8690 blk driver regression
From:	"Magenheimer, Dan (HP Labs Fort Collins)" <dan.magenheimer@xxxxxx>
Date:	Tue, 31 Jan 2006 14:48:15 -0800
Cc:	xen-devel@xxxxxxxxxxxxxxxxxxx, sos22@xxxxxxxxx, "Williamson, Alex \(Linux Kernel Dev\)" <alex.williamson@xxxxxx>, xen-ia64-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Tue, 31 Jan 2006 22:58:06 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcYmtoCmx3h1fozqT0aGOytpePMcKgAAX7Kw
Thread-topic:	[Xen-ia64-devel] cset 8690 blk driver regression

These were two separate bugs.  Backing out
(or otherwise rewriting) that patch is still
necessary for domU to boot on ia64.

A gnttab_shared_gpfn macro sounds good to me!
(assuming defined to the pre-patch lines for
ia64 and the post-patch lines for x86?)

Thanks,
Dan

> -----Original Message-----
> From: Keir Fraser [mailto:Keir.Fraser@xxxxxxxxxxxx] 
> Sent: Tuesday, January 31, 2006 3:33 PM
> To: Magenheimer, Dan (HP Labs Fort Collins)
> Cc: Williamson, Alex (Linux Kernel Dev); 
> xen-ia64-devel@xxxxxxxxxxxxxxxxxxx; 
> xen-devel@xxxxxxxxxxxxxxxxxxx; sos22@xxxxxxxxx
> Subject: Re: [Xen-ia64-devel] cset 8690 blk driver regression
> 
> 
> On 31 Jan 2006, at 20:11, Magenheimer, Dan (HP Labs Fort 
> Collins) wrote:
> 
> > To fix it so that it works on x86 (shadow and non-shadow)
> > and ia64, perhaps a macro call could be substituted for
> > the three removed lines and define'd differently for each
> > arch in asm/shadow.h?
> 
> I removed the dummy definition of __mfn_to_gpfn() from xen/shadow.h 
> that was hiding ia64's own definition. I think Alex Williamson posted 
> that as a fix. Is using that macro here not applicable for 
> ia64 at all? 
> If not and the tree is still broken for ia64 then we can 
> perhaps define 
> a gnttab_shared_gpfn() macro.
> 
>   -- Keir
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel