Re: [Xen-devel] Build failure on i386 fedora core 4

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxx>]

On Mon, Jan 30, 2006 at 01:52:07PM -0800, Kamble, Nitin A wrote:
> I am observing xen-unstable build failing on i386 FC4, as seen bellow.
> mm.c:1975: warning: ?mapcache.pfn? may be used uninitialized in this
> function
> 
> mm.c:1975: warning: ?mapcache.va? may be used uninitialized in this
> function

that's a bogus gcc4 warning. the variable is fine and not used
uninitialized, i checked.

I think just not using -Werror for gcc4 is a much better alternative, cf
following patch.

diff -r 690fc13948db xen/arch/x86/Rules.mk
--- a/xen/arch/x86/Rules.mk     Mon Jan 30 13:35:43 2006 +0100
+++ b/xen/arch/x86/Rules.mk     Mon Jan 30 22:40:33 2006 +0000
@@ -8,7 +8,7 @@
 pae ?= n
 
 CFLAGS  += -nostdinc -fno-builtin -fno-common -fno-strict-aliasing
-CFLAGS  += -iwithprefix include -Wall -Werror -Wno-pointer-arith -pipe
+CFLAGS  += -iwithprefix include -Wall -Wno-pointer-arith -pipe
 CFLAGS  += -I$(BASEDIR)/include 
 CFLAGS  += -I$(BASEDIR)/include/asm-x86/mach-generic
 CFLAGS  += -I$(BASEDIR)/include/asm-x86/mach-default
@@ -55,3 +55,7 @@
 $(error gcc-3.1.x unsupported - upgrade to at least gcc-3.2.x)
 endif
 endif
+ifneq ($(call gcc-ver,1),4)
+# gcc 4 have lots of spurious warnings, don't -Werror
+CFLAGS += -Werror
+endif

-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel