Re: [Xen-devel] [PATCH] Null pointer dereference at free_vm_area

On Mon, Dec 26, 2005 at 01:58:57PM -0200, Glauber de Oliveira Costa wrote:
> The free_vm_area() function may crash if it gets a NULL pointer as a
> parameter. I do think that the right behaviour should be returning in
> this case. This is, for example, the same behaviour of kfree(), and as
> alloc_vm_area() may also return NULL, it may lead to a more elegant 
> alloc/free sequence in case of a fail.
>
> In case you agree with that, a patch follows.

Hi,

I quickly look around where free_vm_area is called, and I cannot see any
codepath that could benefit such a code cleanup nor find any that
could lead to a NULL pointer pass to it.

I think you should provide a use for this patch if you want it to be
applied.

Thanks,
-- 
Vincent Hanquez

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Null pointer dereference at free_vm_area(), Glauber de Oliveira Costa Re: [Xen-devel] [PATCH] Null pointer dereference at free_vm_area(), Vincent Hanquez <= Re: [Xen-devel] [PATCH] Null pointer dereference at free_vm_area(), Glauber de Oliveira Costa

Previous by Date:

Re: [Xen-devel] [PATCH] Prevent vbd frontend from oopsing if the underlying device doesn't exist, Vincent Hanquez

Next by Date:

Re: [Xen-devel] [PATCH] Null pointer dereference at free_vm_area(), Glauber de Oliveira Costa

Previous by Thread:

[Xen-devel] [PATCH] Null pointer dereference at free_vm_area(), Glauber de Oliveira Costa

Next by Thread:

Re: [Xen-devel] [PATCH] Null pointer dereference at free_vm_area(), Glauber de Oliveira Costa

Indexes:

[Date] [Thread] [Top] [All Lists]