RE: [Xen-devel] [PATCH]fix VMX "xm console" issue

To:	"Yu, Ping Y" <ping.y.yu@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	RE: [Xen-devel] [PATCH]fix VMX "xm console" issue
From:	"Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>
Date:	Wed, 30 Nov 2005 11:20:21 -0000
Delivery-date:	Wed, 30 Nov 2005 11:20:10 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AcX0kXm6P3GPNQq0SLeZDjrEEl/V+wAO9f4AAAA+AqAAAy+gEAAwrFNQAABlvcA=
Thread-topic:	[Xen-devel] [PATCH]fix VMX "xm console" issue

> >I'd prefer to understand the issue a bit more first/
> The issue is the following: 
> VMX is a unmodified guest OS, and to enable serial output, we 
> should configure the following items in grub.
> 
>   console=tty0 console=ttyS0,9600n8
> 
> for details please refer to:
>   http://people.redhat.com/steved/RemoteConsoleNotes.txt
> 
> Once we configure ttyS0, VMX will use qemu to create a pty in 
> dom0 directly, bypassing xenconsoled. To better support 
> serial output, I add parameter setting function to fix this 
> issue, which is the reason of my patch. :-)

What we're missing is a description of *why* your patch works. Have a
look at Anthony's email and try addressing his points.

We need to get this issue fixed ASAP.

Thanks,
Ian 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel