Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Add a mechanism to detect block device setup fai

To: Murillo Fernandes Bernardes <mfb@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Add a mechanism to detect block device setup failure
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Mon, 31 Oct 2005 16:16:38 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 31 Oct 2005 16:13:45 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200510290111.07669.mfb@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200510290111.07669.mfb@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Sat, Oct 29, 2005 at 01:11:07AM -0200, Murillo Fernandes Bernardes wrote:

> The problem is: There is no mechanism to detect block device setup failure
> 
> Network devices have the same problem, and are fixed with this too.
> 
> I handling this problem in the way suggested by aliguori: 
> - hotplug scripts write a "hotplug-status" node on store
> - Xend DevController.createDevice() check verify this node and return success 
> or throw an exception on failure. 
> - If no changes in "hotplug-status" node after DEVICE_CREATE_TIMEOUT seconds 
> Xend throw an exception showing the problem with hotplug scripts.
> 
> Comments?

Thanks a lot for this, Murillo.  I have a concern that this patch only
protects us against failure of hotplugging, and not, for example, a failure of
the backend driver, but it's certainly a good step in the right direction, so
I've applied it.  I'll be working myself in this area over the next day or two
to improve this further.

Thanks again,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>