Re: [Xen-devel] [PATCH] Changes to allow dynamic enabling/disabling of trace buffers

[David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>]

David Hopwood wrote:
> Rob Gardner wrote:
> 
>     //  3. Changing size ==> deallocate and reallocate? Or disallow?
>     //     User can just do a change to 0, then a change to the new size.
> 
> They can, but the interface is slightly simpler if you allow this, and
> the implementation is also slightly shorter because you don't have to
> check for the error, or comment on it:
[...]
> The sentence "To change the size of an existing allocation, you must first
> deallocate it then reallocate it." should also be removed from the
> xc_tbuf_set_size doc comment.

For the implementation I gave, replace it with
"If the call fails (e.g. due to lack of memory), the size may be set to zero."

-- 
David Hopwood <david.nospam.hopwood@xxxxxxxxxxxxxxxx>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel