[Xen-devel] RE: [PATCH][1/10] Device model cleanup.

["Ian Pratt" <m+Ian.Pratt@xxxxxxxxxxxx>]

> Device model cleanup.
> 
> - Single config file for xen and device models
>   (Shell script doesn't source xmdefconfig anymore)
> - No more device-model shell script by default. You can
>   have one if needed (qemu-dm.debug)
> - All logic in the script device-model is moved to python
> - $DISPLAY is passed from xm to xend
> - Don't fork vncviewer on dryruns
> - Add support for killing device models on domain destroy
> - info vmxiopage command added to the monitor
> - Refactor shared io page into global and per vcpu state
> - Remove the hard coding of IOPACKET_PORT
> - move the virtual_platform_def up to domain struct from vcpu
> - xm create -n:

This is useful progress, but I have a couple of comments/questions.

* should the empty config options be appearing in the sxp? I don't think
so. Further, perhaps they should be wrapped in a (ioemu ...) section?

* we should make it such that disks can be specified using the same
syntax as for normal paravirt drives e.g. file:, phy: etc.

* I presume that the vncviewer is being forked from xm, but that the
vncconect is being issued from xend, which is why it needs the $DISPLAY
?    

* we still need some tests when building to ensure libvncserver and
libsvg are installed. As the current behaviour when they're not is
confusing -- I think its better to refuse to build ioemu if they're not
installed.

* we should move qemu-dm from /usr/bin to /usr/lib/xen/bin

* files like mem-map.sxp should probably live in /usr/lib/xen/boot

* presumably we no longer need bochsrc ?

Thanks,
Ian

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel