Re: [Xen-devel] [PATCH] xen-booloader: pygrub improvement & bug fix

[Jeremy Katz <katzj@xxxxxxxxxx>]

On Fri, 2005-04-29 at 12:56 +0900, aq wrote:
> here is a patch to improve and fix few bugs in pygrub of xen-booloader. 

Cool, thanks.  Comments below

> List of changes:
> - temporarily remove usage of use_default_colors(), since python 2.3
> doesnt support this method.

It would be better to actually check for the method and call it if
available.. something like
  if hasattr(curses, 'use_default_colors') curses.use_default_colors()

> - allow user to press 'q' to quit pygrub

I had this at one point and then removed it -- the question is if you
quit, then what are you wanting to boot?  I guess it would be aborting
the domain boot (which is the result you get), but thinking further down
the road, what does that mean on a reboot?  So I just decided the best
thing to do was not to allow this.  

> - deinitialize curses before quitting.

curses should get de-initialized when you leave curses.wrapper -- are
you not seeing this?

Thanks,

Jeremy


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel