[Xen-devel] Re: [PATCH] xen bootloader

To:	Jeremy Katz <katzj@xxxxxxxxxx>
Subject:	[Xen-devel] Re: [PATCH] xen bootloader
From:	aq <aquynh@xxxxxxxxx>
Date:	Fri, 29 Apr 2005 12:25:04 +0900
Cc:	Mike Wray <mike.wray@xxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Fri, 29 Apr 2005 03:24:44 +0000
Domainkey-signature:	a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=p2LozvUfZWtrDn5RVr2rDZ8tBR3L8+JZDsbELPhCzp52UxIxcvRZdKrnNnCfz6TPBsOLxa53ov5YY2TbvbiNoH3q37+EuIgwBDDzmvAm1Nx6h1G1dvYIAPyVfSNF3QRXCW9vgpM3D9ST3qrlwaSgodOq89VPkzycOXT3BCyuaJA=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to:	<1114744237.17750.39.camel@xxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<9cde8bff0504270221eded71f@xxxxxxxxxxxxxx> <1114744237.17750.39.camel@xxxxxxxxxxxxxx>
Reply-to:	aq <aquynh@xxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

On 4/29/05, Jeremy Katz <katzj@xxxxxxxxxx> wrote:
> On Wed, 2005-04-27 at 18:21 +0900, aq wrote:
> > Here is a patch to fix few problems in Xen bootloader you sent to the
> > list yesterday.
> 
> Thanks.  Sorry for the delay in responding, I've been underwater with
> stuff for FC4 test3.
> 
> > list of changes:
> > - make a dummy tools/pygrub/src/__init__.py
> 
> I still don't know why this didn't work, but thanks.
> 
> > - extend filesystem abstraction by adding file_exist() method. this
> > method is used to check for existent of a file given its name. now
> > ext2fs implements this method.
> 
> Great, thanks.  My only comment about the ext2fs code for this is that
> you might as well inline the contents of ext2_file_exist in
> ext2fs_file_exist... you don't gain anything by having that for reuse
> that I can see.

I agree.

By the way, I am working on xfs/jfs/reiserfs module for this code.
Hopefully I will finish soon.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel