[Xen-changelog] [xen-3.2-testing] vt-d: Fix double spin_lock_irqsave().

["Xen patchbot-3.2-testing" <patchbot-3.2-testing@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1216377012 -3600
# Node ID 18402fdac81988aef300b694db7c2aa5f10a5c5d
# Parent  4539e0ec232a931012b6d62c3318cdd176bca5b3
vt-d: Fix double spin_lock_irqsave().

The duplicate spin_lock_irqsave() flushes the original EFLAGS saved,
and thus disables local irqs permanently.

Signed-off-by: Dexuan Cui <dexuan.cui@xxxxxxxxx>
---
 xen/arch/x86/hvm/vmx/vtd/intel-iommu.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -r 4539e0ec232a -r 18402fdac819 xen/arch/x86/hvm/vmx/vtd/intel-iommu.c
--- a/xen/arch/x86/hvm/vmx/vtd/intel-iommu.c    Fri Jul 18 11:29:53 2008 +0100
+++ b/xen/arch/x86/hvm/vmx/vtd/intel-iommu.c    Fri Jul 18 11:30:12 2008 +0100
@@ -1410,9 +1410,9 @@ void reassign_device_ownership(
 
         /* Move pci device from the source domain to target domain. */
         spin_lock_irqsave(&source_hd->iommu_list_lock, flags);
-        spin_lock_irqsave(&target_hd->iommu_list_lock, flags);
+        spin_lock(&target_hd->iommu_list_lock);
         list_move(&pdev->list, &target_hd->pdev_list);
-        spin_unlock_irqrestore(&target_hd->iommu_list_lock, flags);
+        spin_unlock(&target_hd->iommu_list_lock);
         spin_unlock_irqrestore(&source_hd->iommu_list_lock, flags);
 
         for_each_pdev ( source, pdev2 )

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog