Xen 
 
Home About Xen.org Xen Xen Summit Wiki Mailing List Bug Tracker Xen Downloads
 
   
 

xen-changelog

[Xen-changelog] [linux-2.6.18-xen] kexec: Use error path if crash region

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [linux-2.6.18-xen] kexec: Use error path if crash region range can't be accessed
From: "Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 28 Feb 2008 12:20:23 -0800
Delivery-date: Thu, 28 Feb 2008 12:21:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1204195967 0
# Node ID 439fda3ac2694639fe160a482150f1016d24f9a4
# Parent  c48f543650603e4ba7227925c6b60f2ea6778242
kexec: Use error path if crash region range can't be accessed

Although the error handling path in xen_machine_kexec_setup_resource()
is somewhat minmal, it ought to be used if HYPERVISOR_kexec_op() fails
whengetting the crash kernel region, as this indicates that an error
occured, not that the crash kernel region is empty.

Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
 drivers/xen/core/machine_kexec.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r c48f54365060 -r 439fda3ac269 drivers/xen/core/machine_kexec.c
--- a/drivers/xen/core/machine_kexec.c  Wed Feb 27 13:14:18 2008 +0000
+++ b/drivers/xen/core/machine_kexec.c  Thu Feb 28 10:52:47 2008 +0000
@@ -85,7 +85,7 @@ void __init xen_machine_kexec_setup_reso
        range.range = KEXEC_RANGE_MA_CRASH;
 
        if (HYPERVISOR_kexec_op(KEXEC_CMD_kexec_get_range, &range))
-               return;
+               goto err;
 
        if (range.size) {
                crashk_res.start = range.start;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [linux-2.6.18-xen] kexec: Use error path if crash region range can't be accessed, Xen patchbot-linux-2.6.18-xen <=