[Xen-changelog] [xen-unstable] Consolidate the preferable use of a pragma with the feature detection

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Node ID 807fbfb0a0dcf7c1e2c4c46f10f093d0905e49f3
# Parent  ab2817b9547bf444331bda15adecf0bf8dec55a6
Consolidate the preferable use of a pragma with the feature detection
in the make script.
Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
---
 xen/arch/x86/Rules.mk      |    2 +-
 xen/include/xen/compiler.h |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff -r ab2817b9547b -r 807fbfb0a0dc xen/arch/x86/Rules.mk
--- a/xen/arch/x86/Rules.mk     Mon Sep 25 09:31:11 2006 +0100
+++ b/xen/arch/x86/Rules.mk     Mon Sep 25 09:36:11 2006 +0100
@@ -44,7 +44,7 @@ CFLAGS  += -fno-asynchronous-unwind-tabl
 CFLAGS  += -fno-asynchronous-unwind-tables
 # -fvisibility=hidden reduces -fpic cost, if it's available
 CFLAGS  += $(shell $(CC) -v --help 2>&1 | grep " -fvisibility=" | \
-             grep -q hidden && echo "-fvisibility=hidden")
+             grep -q hidden && echo "-DGCC_HAS_VISIBILITY_ATTRIBUTE")
 LDFLAGS += -m elf_x86_64
 x86_32 := n
 x86_64 := y
diff -r ab2817b9547b -r 807fbfb0a0dc xen/include/xen/compiler.h
--- a/xen/include/xen/compiler.h        Mon Sep 25 09:31:11 2006 +0100
+++ b/xen/include/xen/compiler.h        Mon Sep 25 09:36:11 2006 +0100
@@ -35,7 +35,7 @@
 #define offsetof(a,b) ((unsigned long)&(((a *)0)->b))
 #endif
 
-#if defined(__x86_64__) && (__GNUC__ > 3)
+#ifdef GCC_HAS_VISIBILITY_ATTRIBUTE
 /* Results in more efficient PIC code (no indirections through GOT or PLT). */
 #pragma GCC visibility push(hidden)
 #endif

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog